netdev - Re: [PATCH net-next v2 1/2] ethernet: realtek: use module_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140722.002850.1113335731441581168.davem@davemloft.net>
Date:	Tue, 22 Jul 2014 00:28:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	varkabhadram@...il.com
Cc:	netdev@...r.kernel.org, varkab@...c.in
Subject: Re: [PATCH net-next v2 1/2] ethernet: realtek: use
 module_pci_driver

From: varkabhadram@...il.com
Date: Tue, 22 Jul 2014 12:50:21 +0530

> @@ -1887,11 +1887,7 @@ static int cp_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
>  	resource_size_t pciaddr;
>  	unsigned int addr_len, i, pci_using_dac;
>  
> -#ifndef MODULE
> -	static int version_printed;
> -	if (version_printed++ == 0)
> -		pr_info("%s", version);
> -#endif
> +	pr_info("%s", version);

Now you're changing behavior undesirably, it will now print the
version string into the logs for every instance of the device which is
discovered.

Seriously, the driver is worse off after these "cleanups".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html