netdev - Re: [PATCH net-next 2/9] gue: Support for Generic UDP Encapsulation RX path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Jul 2014 10:07:39 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/9] gue: Support for Generic UDP Encapsulation
 RX path

On Thu, Jul 17, 2014 at 7:14 AM, Tom Herbert <therbert@...gle.com> wrote:
> This patch provides a Generic UDP Encapsulation receive path
> using the XFRM framework (udp_encap_rcv).
>
> This adds support for both direct encapsulation of IP protocols over
> UDP. The bound destination port is used to map to an IP protocol.
> This should support GRE over UDP encapsulation, see
> http://tools.ietf.org/html/draft-yong-tsvwg-gre-in-udp-encap-02,
> as will as the other IP tunneling protocols (IPIP, SIT).
>
> Signed-off-by: Tom Herbert <therbert@...gle.com>
> ---
>  include/net/gue.h |  49 +++++++++++++++++
>  net/ipv4/Kconfig  |  10 ++++
>  net/ipv4/Makefile |   1 +
>  net/ipv4/gue.c    | 159 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 219 insertions(+)
>  create mode 100644 include/net/gue.h
>  create mode 100644 net/ipv4/gue.c
>
> diff --git a/include/net/gue.h b/include/net/gue.h
> new file mode 100644
> index 0000000..86b91bc
> --- /dev/null
> +++ b/include/net/gue.h
> @@ -0,0 +1,49 @@
> +#ifndef __NET_GUE_H
> +#define __NET_GUE_H
> +
> +#if defined(CONFIG_NET_GUE) || defined(CONFIG_NET_GUE_MODULE)
> +
> +#include <net/udp_tunnel.h>
> +
> +struct gue_port_cfg {
> +       u8                      protocol;
> +       struct udp_port_cfg     udp_config;
> +};
> +
> +int gue_port_create(struct net *net, struct gue_port_cfg *cfg,
> +                   struct socket **sockp);
> +int gue_open_direct_port(unsigned short port, unsigned char proto,
> +                        struct socket **sockp);
> +void gue_close_port(struct socket *sock);
> +
> +/* Tunnel protocols can use GUE_TUNNEL_PARMS to set up per module static
> + * variables that are used with the common GUE functions (open_gue_port,
> + * close_gue_port).
> + */
> +#define GUE_TUNNEL_PARMS(name, default_port)                   \
> +static int gue_udp_port = default_port;                                \
> +module_param(gue_udp_port, int, 0);                            \
> +MODULE_PARM_DESC(gue_udp_port, name "/UDP port");              \
> +static struct socket *gue_sock;
> +
> +#define open_gue_port(proto)                                   \
> +       (gue_udp_port ?                                         \
> +        gue_open_direct_port(gue_udp_port, proto, &gue_sock) : \
> +        0)
> +
> +#define close_gue_port() do {                                  \
> +       if (gue_sock) {                                         \
> +               gue_close_port(gue_sock);                       \
> +               gue_sock = NULL;                                \
> +       }                                                       \
> +} while (0)
> +

Hi Tom,

So this is probably a similar feedback to the ioctls vs netlink
comment from Dave...

I guess we agree that module params should be avoided when possible, right? so
this even goes further to a template in a header file used by the
caller modules to define
their own module param...  should be (a non academic, I read your other comment)
alternative here, I hope.

Or.

> +#else /* defined(CONFIG_NET_GUE) || defined(CONFIG_NET_GUE_MODULE) */
> +
> +#define GUE_TUNNEL_PARMS(name, default_port)
> +#define open_gue_port(proto) (0)
> +#define close_gue_port()
> +
> +#endif
> +
> +#endif
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html