lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140724081312.46b533c7@haswell.linuxnetplumber.net>
Date:	Thu, 24 Jul 2014 08:13:12 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Tom Herbert <therbert@...gle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/9] gue: Support for Generic UDP Encapsulation
 RX path

On Wed, 16 Jul 2014 21:14:30 -0700 (PDT)
Tom Herbert <therbert@...gle.com> wrote:

> +
> +#define open_gue_port(proto)					\
> +	(gue_udp_port ?						\
> +	 gue_open_direct_port(gue_udp_port, proto, &gue_sock) :	\
> +	 0)
> +
> +#define close_gue_port() do {					\
> +	if (gue_sock) {						\
> +		gue_close_port(gue_sock);			\
> +		gue_sock = NULL;				\
> +	}							\
> +} while (0)

Macro;s are evil and unnecessary for this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ