netdev - Re: [patch] ISDN: pcbit: off by one bugs in pcbit_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140731.221529.330940073121612159.davem@davemloft.net>
Date:	Thu, 31 Jul 2014 22:15:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	isdn@...ux-pingi.de, arnd@...db.de, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] ISDN: pcbit: off by one bugs in pcbit_set_msn()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Thu, 31 Jul 2014 18:30:11 +0300

> 1) We don't allocate enough space for the NUL terminator so we end up
>    corrupting one character beyond the end of the buffer.
> 
> 2) The "len - 1" should just be "len".  The code is trying to copy a
>    word from a buffer up to a comma or the last word in the buffer.
>    Say you have the buffer, "foo,bar,baz", then this code truncates the
>    last letter off each word so you get "fo", "ba", and "ba".  You would
>    hope this kind of bug would get noticed in testing...
> 
>    I'm not very familiar with this code and I can't test it, but I think
>    we should copy the final character.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied to net-next, thanks Dan.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html