netdev - Re: [PATCH net-next 2/4] inet: frags: rename last_in to flags, enum the definitions and add comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140731.221349.304058285592989214.davem@davemloft.net>
Date:	Thu, 31 Jul 2014 22:13:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nikolay@...hat.com
Cc:	netdev@...r.kernel.org, fw@...len.de, kuznet@....inr.ac.ru,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	alex.aring@...il.com, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 2/4] inet: frags: rename last_in to flags,
 enum the definitions and add comments

From: Nikolay Aleksandrov <nikolay@...hat.com>
Date: Thu, 31 Jul 2014 17:11:37 +0200

> The last_in field has been used to store various flags different from
> first/last frag in so give it a more descriptive name: flags. Move
> the flags to an enum definion, swap FIRST_IN/LAST_IN to be in logical
> order and add comments explaining each flag, also add comments explaining
> the inet_frag_queue struct members. While at it align some function
> declarations.

When I hear things like "also" and "while at it", what I really hear is
"that should be done in a separate patch".

Please don't clump so many unrelated changes together, it makes the
patch harder to review than necessary, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html