netdev - Re: [PATCH net-next 2/4] inet: frags: rename last_in to flags, enum the definitions and add comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53DB4F7E.2070001@redhat.com>
Date:	Fri, 01 Aug 2014 10:27:42 +0200
From:	Nikolay Aleksandrov <nikolay@...hat.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, fw@...len.de, kuznet@....inr.ac.ru,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	alex.aring@...il.com, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 2/4] inet: frags: rename last_in to flags, enum
 the definitions and add comments

On 08/01/2014 07:13 AM, David Miller wrote:
> From: Nikolay Aleksandrov <nikolay@...hat.com>
> Date: Thu, 31 Jul 2014 17:11:37 +0200
> 
>> The last_in field has been used to store various flags different from
>> first/last frag in so give it a more descriptive name: flags. Move
>> the flags to an enum definion, swap FIRST_IN/LAST_IN to be in logical
>> order and add comments explaining each flag, also add comments explaining
>> the inet_frag_queue struct members. While at it align some function
>> declarations.
> 
> When I hear things like "also" and "while at it", what I really hear is
> "that should be done in a separate patch".
> 
> Please don't clump so many unrelated changes together, it makes the
> patch harder to review than necessary, thanks.
> 
Sorry about that, but I thought aligning 2-3 function declarations in
inet_fragment.c was not worth a separate patch.
Anyway I'll break the aligning out.

Thanks,
 Nik
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html