netdev - Re: [PATCH net-next] ipv6: rename __ipv6_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1406875575.3178.55.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 01 Aug 2014 08:46:15 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH net-next] ipv6: rename __ipv6_addr_jhash()

On Thu, 2014-07-31 at 21:56 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Wed, 30 Jul 2014 23:38:18 +0200
> 
> > From: Eric Dumazet <edumazet@...gle.com>
> > 
> > Remove '__' prefix, it has no purpose.
> > 
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> 
> Actually, I think it does.
> 
> If you look at where this came from, it's commit:
> 
> commit b50026b5ac8fe2932e6af0c54b21da0913c4c1c7
> Author: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Date:   Sat Oct 19 21:48:52 2013 +0200
> 
>     ipv6: split inet6_ehashfn to hash functions per compilation unit
> 
> and in that change Hannes uses the convention that __foo() functions
> take an initval argument for the hash computation where as foo()
> functions do not.
> 
> I'm not applying this, sorry :)

Well, there is no ipv6_addr_jhash() anymore.

Should we rename jhash() to __jhash() then ????

This seems pretty odd and useless.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html