netdev - Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407335781.11943.9.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 06 Aug 2014 16:36:21 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Willem de Bruijn <willemb@...gle.com>
Cc:	Network Development <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

On Wed, 2014-08-06 at 09:08 -0400, Willem de Bruijn wrote:

> Thanks for spotting and fixing the critical shared frags issue. I
> can send a patch for this, the two static functions identified by
> sparse and the sequence number arithmetic in tcp_gso_tstamp.

Please send the patch, as I am quite busy today.

Another issue is your should set the flag, not clearing others in
tcp_gso_tstamp()

	skb_shinfo(skb)->tx_flags |= SKBTX_SW_TSTAMP;


Not sure if this matters at the moment, but it would be cleaner anyway.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html