netdev - Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407335823.11943.10.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 06 Aug 2014 16:37:03 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Willem de Bruijn <willemb@...gle.com>
Cc:	Network Development <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

On Wed, 2014-08-06 at 10:23 -0400, Willem de Bruijn wrote:
> > I believe you missed fact that a GSO packet can be split into 2 or many
> > skbs, when tcp_write_xmit() has to send a lower amount.
> >
> > This is done in tso_fragment()
> 
> Thanks, I missed that case. I'll look into it.
> 
> > Also, I am a bit worried about retransmits ?
> 
> For the same reason, i.e., possibly calling tcp_fragment?

Yes, but also that we're going to send multiple reports back to error
queue.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html