netdev - Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407306307.14097.2.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 06 Aug 2014 08:25:07 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Willem de Bruijn <willemb@...gle.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	richardcochran@...il.com
Subject: Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

On Mon, 2014-08-04 at 22:11 -0400, Willem de Bruijn wrote:

...

> diff --git a/net/ipv4/tcp_offload.c b/net/ipv4/tcp_offload.c
> index 55046ec..f597119 100644
> --- a/net/ipv4/tcp_offload.c
> +++ b/net/ipv4/tcp_offload.c
> @@ -14,6 +14,21 @@
>  #include <net/tcp.h>
>  #include <net/protocol.h>
>  
> +void tcp_gso_tstamp(struct sk_buff *skb, unsigned int ts_seq, unsigned int seq,
> +		    unsigned int mss)

static void ...

Or else :

make C=2 net/ipv4/tcp_offload.o
  CHECK   net/ipv4/tcp_offload.c
net/ipv4/tcp_offload.c:17:6: warning: symbol 'tcp_gso_tstamp' was not
declared. Should it be static?


> +{
> +	while (skb) {
> +		if (ts_seq < (__u64) seq + mss) {

TCP stack uses after() and/or before() macros when dealing with 32bit
sequence numbers.

> +			skb_shinfo(skb)->tx_flags = SKBTX_SW_TSTAMP;
> +			skb_shinfo(skb)->tskey = ts_seq;
> +			return;
> +		}
> +
> +		skb = skb->next;
> +		seq += mss;
> +	}
> +}
> +



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html