netdev - Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407308141.14097.9.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 06 Aug 2014 08:55:41 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Willem de Bruijn <willemb@...gle.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	richardcochran@...il.com
Subject: Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

On Mon, 2014-08-04 at 22:11 -0400, Willem de Bruijn wrote:
> TCP timestamping extends SO_TIMESTAMPING to bytestreams.

> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index 9d2118e..744af67 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -426,6 +426,15 @@ void tcp_init_sock(struct sock *sk)
>  }
>  EXPORT_SYMBOL(tcp_init_sock);
>  
> +void tcp_tx_timestamp(struct sock *sk, struct sk_buff *skb)
> +{
> +	struct skb_shared_info *shinfo = skb_shinfo(skb);
> +
> +	sock_tx_timestamp(sk, &shinfo->tx_flags);

Arg, this breaks SKBTX_SHARED_FRAG support.

And sock_tx_timestamp() is quite expensive for TCP where only
SKBTX_ACK_TSTAMP could possibly be supported ?

> +	if (shinfo->tx_flags & SKBTX_ANY_SW_TSTAMP)
> +		shinfo->tskey = TCP_SKB_CB(skb)->seq + skb->len - 1;
> +}


static void tcp_tx_timestamp(const struct sock *sk, struct sk_buff *skb)

I'll send a cumulative patch.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html