netdev - Re: [PATCH v4] net: gianfar: fix reference counting for phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140807.160609.329034989608056160.davem@davemloft.net>
Date:	Thu, 07 Aug 2014 16:06:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	u.kleine-koenig@...gutronix.de
Cc:	netdev@...r.kernel.org, claudiu.manoil@...escale.com,
	kernel@...gutronix.de, f.fainelli@...il.com,
	fabio.estevam@...escale.com, thomas.petazzoni@...e-electrons.com
Subject: Re: [PATCH v4] net: gianfar: fix reference counting for phy_node

From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Date: Thu,  7 Aug 2014 22:17:07 +0200

> The line before the changed if condition is:
> 
> 	priv->phy_node = of_parse_phandle(np, "phy-handle", 0);
> 
> . If this call succeeds priv->phy_node must not be overwritten in the if
> block; otherwise the reference to the node returned by of_parse_phandle
> is lost. So add a check that the if block isn't executed in this case.
> 
> Furthermore in the fixed phy case no reference is aquired for phy_node
> resulting in an of_node_put without holding a reference. To fix that,
> get a reference on the MAC dt node.
> 
> Fixes: be40364544bd ("gianfar: use the new fixed PHY helpers")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html