netdev - Re: [PATCH net] netlink: reset network header before passing to taps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140807.160617.1417231506028535686.davem@davemloft.net>
Date:	Thu, 07 Aug 2014 16:06:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dborkman@...hat.com
Cc:	netdev@...r.kernel.org, marcel@...tmann.org
Subject: Re: [PATCH net] netlink: reset network header before passing to
 taps

From: Daniel Borkmann <dborkman@...hat.com>
Date: Thu,  7 Aug 2014 22:22:47 +0200

> netlink doesn't set any network header offset thus when the skb is
> being passed to tap devices via dev_queue_xmit_nit(), it emits klog
> false positives due to it being unset like:
> 
>   ...
>   [  124.990397] protocol 0000 is buggy, dev nlmon0
>   [  124.990411] protocol 0000 is buggy, dev nlmon0
>   ...
> 
> So just reset the network header before passing to the device; for
> packet sockets that just means nothing will change - mac and net
> offset hold the same value just as before.
> 
> Reported-by: Marcel Holtmann <marcel@...tmann.org>
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html