netdev - Re: sel_netif_init: 'err' is used uninitialized (was: Re: selinux: reduce the number of calls to synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5750080.46d2jsPKXX@sifl>
Date:	Thu, 07 Aug 2014 10:26:14 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-security-module@...r.kernel.org,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: sel_netif_init: 'err' is used uninitialized (was: Re: selinux: reduce the number of calls to synchronize_net() when flushing caches)

On Thursday, August 07, 2014 12:31:15 PM Geert Uytterhoeven wrote:
> 
> security/selinux/netif.c: In function ‘sel_netif_init’:
> /scratch/geert/linux/linux-m68k/security/selinux/netif.c:285: warning:
> ‘err’ is used uninitialized in this function
> 
> Should it just return 0, like before?
> Or should it return the return value of register_netdevice_notifier()
> instead, which also returns an error code? Or is that failure non-critical?

Hi,

I posted a fix for this two days ago to the SELinux list (see below).  As soon 
as -rc1 is released and linux-next is back in business I'll be pushing the 
patch to the SELinux #next branch.

 * http://marc.info/?l=selinux&m=140727033030054&w=2

-- 
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html