lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Aug 2014 16:57:30 +0200 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Paul Moore <paul@...l-moore.com> Cc: linux-security-module@...r.kernel.org, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: sel_netif_init: 'err' is used uninitialized (was: Re: selinux: reduce the number of calls to synchronize_net() when flushing caches) Hi Paul, On Thu, Aug 7, 2014 at 4:26 PM, Paul Moore <paul@...l-moore.com> wrote: > On Thursday, August 07, 2014 12:31:15 PM Geert Uytterhoeven wrote: >> >> security/selinux/netif.c: In function ‘sel_netif_init’: >> /scratch/geert/linux/linux-m68k/security/selinux/netif.c:285: warning: >> ‘err’ is used uninitialized in this function >> >> Should it just return 0, like before? >> Or should it return the return value of register_netdevice_notifier() >> instead, which also returns an error code? Or is that failure non-critical? > > Hi, > > I posted a fix for this two days ago to the SELinux list (see below). As soon > as -rc1 is released and linux-next is back in business I'll be pushing the > patch to the SELinux #next branch. > > * http://marc.info/?l=selinux&m=140727033030054&w=2 Thanks, I had a quick look for it, but couldn't find it. It's always a good idea to CC lkml for such issues in mainline. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists