netdev - Re: [PATCH net 1/2] net-timestamp: fix missing ACK timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140812.151625.928342154282151683.davem@davemloft.net>
Date:	Tue, 12 Aug 2014 15:16:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	willemb@...gle.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	richardcochran@...il.com
Subject: Re: [PATCH net 1/2] net-timestamp: fix missing ACK timestamp

From: Willem de Bruijn <willemb@...gle.com>
Date: Tue, 12 Aug 2014 14:53:16 -0400

> ACK timestamps are generated in tcp_clean_rtx_queue. The TSO datapath
> can break out early, causing the timestamp code to be skipped. Move
> the code up before the break.
> 
> Reported-by: David S. Miller <davem@...emloft.net>
> 
> Also fix a boundary condition: tp->snd_una is the next unacknowledged
> byte and between tests inclusive (a <= b <= c), so generate a an ACK
> timestamp if (prior_snd_una <= tskey <= tp->snd_una - 1).
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html