netdev - Re: [PATCH] rtlwifi: btcoexist: adjust double test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53EA91C7.5010103@lwfinger.net>
Date:	Tue, 12 Aug 2014 17:14:31 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Himangi Saraogi <himangi774@...il.com>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
CC:	julia.lawall@...6.fr
Subject: Re: [PATCH] rtlwifi: btcoexist: adjust double test

On 08/12/2014 02:39 PM, Himangi Saraogi wrote:
> Rewrite a duplicated test to test the correct value
> 
> The Coccinelle semantic patch that finds this problem is:
> 
> // <smpl>
> @@
> expression E;
> @@
> 
> (
> * E
>   || ... || E
> |
> * E
>   && ... && E
> )
> // </smpl>
> 
> Signed-off-by: Himangi Saraogi <himangi774@...il.com>
> ---
> In file drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.c, there is a
> similar function that tests for WIRELESS_MODE_G and WIRELESS_MODE_B.
> I have not tested the code, so you am not sure whether it is the
> correct solution.
> 
>  drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.c
> index 33da3df..d4bd550 100644
> --- a/drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.c
> +++ b/drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.c
> @@ -101,7 +101,7 @@ static bool halbtc_legacy(struct rtl_priv *adapter)
>  
>  	bool is_legacy = false;
>  
> -	if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_B))
> +	if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_G))
>  		is_legacy = true;
>  
>  	return is_legacy;

The latest version of the vendor driver has this change already applied.

Acked-by: Larry.Finger <Larry.Finger@...inger.net>

Larry


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html