netdev - RE: [PATCH net-next] libcxgbi/cxgb4i : Fix ipv6 build failure caught with randconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <525DB349B3FB5444AE057A887CB2A8D859F81B@nice.asicdesigners.com>
Date:	Tue, 12 Aug 2014 22:40:35 +0000
From:	Anish Bhatt <anish@...lsio.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"hch@...radead.org" <hch@...radead.org>,
	Karen Xie <kxie@...lsio.com>,
	Manoj Malviya <manojmalviya@...lsio.com>,
	"jim.epost@...il.com" <jim.epost@...il.com>,
	"sfr@...b.auug.org.au" <sfr@...b.auug.org.au>
Subject: RE: [PATCH net-next] libcxgbi/cxgb4i : Fix ipv6 build failure
 caught with randconfig

So the recommended fix would be that the inbuilt option for cxgbi should be
disabled if ipv6 is compiled as a module ?

This patch was based on code currently in net-next, and I presumed that would
be the correct way to go. I'll change it and rebase to net.
-Anish
________________________________________
From: David Miller [davem@...emloft.net]
Sent: Tuesday, August 12, 2014 3:22 PM
To: Anish Bhatt
Cc: netdev@...r.kernel.org; hch@...radead.org; Karen Xie; Manoj Malviya; jim.epost@...il.com; sfr@...b.auug.org.au
Subject: Re: [PATCH net-next] libcxgbi/cxgb4i : Fix ipv6 build failure caught with randconfig

From: Anish Bhatt <anish@...lsio.com>
Date: Tue, 12 Aug 2014 14:54:41 -0700

> Previous guard of IS_ENABLED(CONFIG_IPV6) is not sufficient when cxgbi drivers
> are built into kernel but ipv6 is not. Change guard to only enable when either
> ipv6 is built-in or both are modules.
>
> Fixes: e81fbf6cd652 ("libcxgbi:cxgb4i Guard ipv6 code with a config check")
> Fixes: fc8d0590d914 ("libcxgbi: Add ipv6 api to driver")
> Signed-off-by: Anish Bhatt <anish@...lsio.com>

That's not how you fix problems like this.

Instead, you should use Kconfig conditions to make sure your driver is
enabled in a manner which is compatible with what IPV6 has been set to.

No user should have to know about these strange dependencies just to get
IPV6 enabled in your driver.

Really, your change makes IPV6 get disabled if IPV6 is modular and your
driver is built statically.  I do not think any user would consider that
reasonable behavior.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html