netdev - Re: [PATCH net-next] libcxgbi/cxgb4i : Fix ipv6 build failure caught with randconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140812.154652.1490202340036045493.davem@davemloft.net>
Date:	Tue, 12 Aug 2014 15:46:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	anish@...lsio.com
Cc:	netdev@...r.kernel.org, hch@...radead.org, kxie@...lsio.com,
	manojmalviya@...lsio.com, jim.epost@...il.com, sfr@...b.auug.org.au
Subject: Re: [PATCH net-next] libcxgbi/cxgb4i : Fix ipv6 build failure
 caught with randconfig

From: Anish Bhatt <anish@...lsio.com>
Date: Tue, 12 Aug 2014 22:40:35 +0000

> So the recommended fix would be that the inbuilt option for cxgbi
> should be disabled if ipv6 is compiled as a module ?

If IPV6 is enabled, you should only allow cxgbi to be enabled in
a mode which is "compatible" with that setting.

This means if IPV6 is enabled statically, cxgbi should be offered
both statically and modular.  Whereas if IPV6 is modular, cxgbi
should only be offered to be enabled modular.

This occurs often enough that there is a common pattern for this
kind of dependency:

	depends on IPV6 || IPV6=n

Alternatively, depending upon what IPV6 interfaces you need to use
in the cxgbi driver, you can potentially move them into the ipv6
components we've split out to always be statically built into the
kernel in order to avoid problems of this nature.  See the code
linked in by the "obj-y +=" rule in net/ipv6/Makefile.

> This patch was based on code currently in net-next, and I presumed that would
> be the correct way to go. I'll change it and rebase to net.

The net-next tree isn't even open and active at this time, I said last week
(as I do every single merge window) that I would explicitly announce on
netdev when the net-next tree is openned.

But, much more importantly, bug fixes for issues present in 'net'
should always be targetted to the 'net' tree.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html