netdev - Re: [PATCH 2/2] ipv4: add a sock pointer to dst->output() path.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140814.151644.1076362729497460962.davem@redhat.com>
Date:	Thu, 14 Aug 2014 15:16:44 -0700 (PDT)
From:	David Miller <davem@...hat.com>
To:	jiri@...nulli.us
Cc:	eric.dumazet@...il.com, nasa4836@...il.com, jchapman@...alix.com,
	lucien.xin@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ipv4: add a sock pointer to dst->output() path.

From: Jiri Pirko <jiri@...nulli.us>
Date: Wed, 13 Aug 2014 19:02:43 +0200

> The question is, is it the correct way? Or perhaps something like
> skb->output_sk would serve this better?

Adding members to sk_buff is strongly discouraged, especially when the
issue here is simply rearranging things, as needed, so that it's easy
to pass the 'sk' through the call chain.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html