netdev - Re: [PATCH 2/2] ipv4: add a sock pointer to dst->output() path.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140815051059.GA1923@nanopsycho.orion>
Date:	Fri, 15 Aug 2014 07:10:59 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	David Miller <davem@...hat.com>
Cc:	eric.dumazet@...il.com, nasa4836@...il.com, jchapman@...alix.com,
	lucien.xin@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ipv4: add a sock pointer to dst->output() path.

Fri, Aug 15, 2014 at 12:16:44AM CEST, davem@...hat.com wrote:
>From: Jiri Pirko <jiri@...nulli.us>
>Date: Wed, 13 Aug 2014 19:02:43 +0200
>
>> The question is, is it the correct way? Or perhaps something like
>> skb->output_sk would serve this better?
>
>Adding members to sk_buff is strongly discouraged, especially when the
>issue here is simply rearranging things, as needed, so that it's easy
>to pass the 'sk' through the call chain.

I feared that. Cooking up a patch. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html