lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 14 Aug 2014 16:47:40 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Ming Liu <liu.ming50@...il.com>
Cc:	steffen.klassert@...unet.com, davem@...emloft.net,
	linux-crypto@...r.kernel.org, netdev@...r.kernel.org,
	Xue Ying <ying.xue@...driver.com>
Subject: Re: HELP: IPsec reordering issue

On Sun, Aug 03, 2014 at 05:57:06PM +0800, Ming Liu wrote:
> 
> Please review this attached patch instead, the original one has a
> problem causing the kernel crash.

Thanks for the patch.  I think it would better to enforce ordering
for all operations rather than treat encryptions separately from
decryptions.  We could conceivably have more complex operations made
up from both encryptions and decryptions that could then get
out-of-order.

It would also make the code simpler.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists