netdev - Re: HELP: IPsec reordering issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5462D428.7060008@windriver.com>
Date:	Wed, 12 Nov 2014 11:29:44 +0800
From:	Ming Liu <ming.liu@...driver.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	<steffen.klassert@...unet.com>, <davem@...emloft.net>,
	<linux-crypto@...r.kernel.org>, <netdev@...r.kernel.org>,
	Xue Ying <ying.xue@...driver.com>
Subject: Re: HELP: IPsec reordering issue

Hi, Herbert:

I've figured out a new patch for this issue reported by me previously, 
the basic idea is adding a cryptd_flush_queue function fixing it by 
being called from softirq to flush all previous queued elements before 
processing a new one, and it works very well so far per my test,  would 
you please review it?

the best,
thank you

On 08/14/2014 04:47 PM, Herbert Xu wrote:
> On Sun, Aug 03, 2014 at 05:57:06PM +0800, Ming Liu wrote:
>> Please review this attached patch instead, the original one has a
>> problem causing the kernel crash.
> Thanks for the patch.  I think it would better to enforce ordering
> for all operations rather than treat encryptions separately from
> decryptions.  We could conceivably have more complex operations made
> up from both encryptions and decryptions that could then get
> out-of-order.
>
> It would also make the code simpler.
>
> Cheers,


View attachment "0001-crypto-aesni-intel-avoid-IPsec-re-ordering.patch" of type "text/x-patch" (9529 bytes)