netdev - Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140821091819.GA2230@msilap.einon.net>
Date:	Thu, 21 Aug 2014 10:18:19 +0100
From:	Mark Einon <mark.einon@...il.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

On Wed, Aug 20, 2014 at 07:22:54PM -0300, Fabio Estevam wrote:
> On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon <mark.einon@...il.com> wrote:
> 
> >                         do {
> >                                 pci_read_config_dword(pdev,
> > -                                       LBCIF_DATA_REGISTER, &val);
> > +                                                     LBCIF_DATA_REGISTER,
> > +                                                     &val);
> 
> This seems to be an unrelated change.

Hi Fabio, thanks for the review.

It's a space alignment of parameters to go with the previous change, to
keep wrapping consistent in the file:

-       while (i2c_wack) {
+       while (1) {
                if (pci_write_config_byte(pdev, LBCIF_CONTROL_REGISTER,
-                       LBCIF_CONTROL_LBCIF_ENABLE))
+                                         LBCIF_CONTROL_LBCIF_ENABLE))

So what are you saying - are you just commenting, document it, put it
in a seperate patch?

Cheers,

Mark
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html