netdev - Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53F55423.7030902@gmail.com>
Date:	Wed, 20 Aug 2014 22:06:27 -0400
From:	Vlad Yasevich <vyasevich@...il.com>
To:	Zhu Yanjun <zyjzyj2000@...il.com>, dborkman@...hat.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	tuexen@...muenster.de, khandelwal.deepak.1987@...il.com,
	Yue.Tao@...driver.com, alexandre.dietsch@...driver.com,
	davem@...emloft.net
CC:	Zhu Yanjun <Yanjun.Zhu@...driver.com>
Subject: Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications
 with failed probe

On 08/20/2014 05:31 AM, Zhu Yanjun wrote:
> Since the transport has always been in state SCTP_UNCONFIRMED, it
> therefore wasn't active before and hasn't been used before, and it
> always has been, so it is unnecessary to bug the user with a 
> notification.
> 
> Reported-by: Deepak Khandelwal <khandelwal.deepak.1987@...il.com>  
> Suggested-by: Vlad Yasevich <vyasevich@...il.com> 
> Suggested-by: Michael Tuexen <tuexen@...muenster.de>
> Suggested-by: Daniel Borkmann <dborkman@...hat.com>
> Signed-off-by: Zhu Yanjun <Yanjun.Zhu@...driver.com>

Acked-by: Vlad Yasevich <vyasevich@...il.com>

Thanks
-vlad
> ---
>  net/sctp/associola.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/sctp/associola.c b/net/sctp/associola.c
> index 9de23a2..2e23f6b 100644
> --- a/net/sctp/associola.c
> +++ b/net/sctp/associola.c
> @@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
>  		else {
>  			dst_release(transport->dst);
>  			transport->dst = NULL;
> +			ulp_notify = false;
>  		}
>  
>  		spc_state = SCTP_ADDR_UNREACHABLE;
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html