netdev - Re: [PATCH net v2] cxgb4: Fix race condition in cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140821115401.GB1237@hmsreliant.think-freely.org>
Date:	Thu, 21 Aug 2014 07:54:01 -0400
From:	Neil Horman <nhorman@...hat.com>
To:	Anish Bhatt <anish@...lsio.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	hariprasad@...lsio.com, leedom@...lsio.com, svemuri@...lsio.com
Subject: Re: [PATCH net v2] cxgb4: Fix race condition in cleanup

On Wed, Aug 20, 2014 at 01:44:06PM -0700, Anish Bhatt wrote:
> There is a possible race condition when we unregister the PCI Driver and then
> flush/destroy the global "workq". This could lead to situations where there
> are tasks on the Work Queue with references to now deleted adapter data
> structures. Instead, have per-adapter Work Queues which were instantiated and
> torn down in init_one() and remove_one(), respectively.
> 
> v2: Remove unnecessary call to flush_workqueue() before destroy_workqueue()
> 
> Signed-off-by: Anish Bhatt <anish@...lsio.com>
> Signed-off-by: Casey Leedom <leedom@...lsio.com>
Acked-by: Neil Horman <nhorman@...driver.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html