lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 21 Aug 2014 09:06:40 -0300
From:	Fabio Estevam <>
To:	Mark Einon <>
Cc:	Greg Kroah-Hartman <>,,
	"" <>,
	linux-kernel <>
Subject: Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

Hi Mark,

On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon <> wrote:

> Hi Fabio, thanks for the review.
> It's a space alignment of parameters to go with the previous change, to
> keep wrapping consistent in the file:
> -       while (i2c_wack) {
> +       while (1) {
>                 if (pci_write_config_byte(pdev, LBCIF_CONTROL_REGISTER,
> -                       LBCIF_CONTROL_LBCIF_ENABLE))
> +                                         LBCIF_CONTROL_LBCIF_ENABLE))
> So what are you saying - are you just commenting, document it, put it
> in a seperate patch?

Yes, it would be better if this part was part of a separate patch.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists