lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Aug 2014 21:39:29 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jonas.jensen@...il.com Cc: netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, f.fainelli@...il.com, eric.dumazet@...il.com Subject: Re: [PATCH v5 1/2] net: moxa: clear TX descriptor length bits From: Jonas Jensen <jonas.jensen@...il.com> Date: Wed, 20 Aug 2014 16:18:42 +0200 > @@ -348,7 +348,8 @@ static int moxart_mac_start_xmit(struct sk_buff *skb, struct net_device *ndev) > > txdes1 = readl(desc + TX_REG_OFFSET_DESC1); > txdes1 |= TX_DESC1_LTS | TX_DESC1_FTS; > - txdes1 &= ~(TX_DESC1_FIFO_COMPLETE | TX_DESC1_INTR_COMPLETE); > + txdes1 &= ~(TX_DESC1_FIFO_COMPLETE | TX_DESC1_INTR_COMPLETE | > + TX_DESC1_BUF_SIZE_MASK); > txdes1 |= (len & TX_DESC1_BUF_SIZE_MASK); > writel(txdes1, desc + TX_REG_OFFSET_DESC1); > writel(TX_DESC0_DMA_OWN, desc + TX_REG_OFFSET_DESC0); Like others I wonder why the existing descriptor value is being read at all. It's inefficient and completely unnecessary, you can just compute a new value from scratch, and that way all of these "uncleared field" issues just automatically disappear. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists