lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACmBeS010Vbgx8wz9YkiQGi4gF6JNQqVRcgYtkCKGqvNs4sopA@mail.gmail.com> Date: Mon, 25 Aug 2014 16:23:09 +0200 From: Jonas Jensen <jonas.jensen@...il.com> To: Michał Mirosław <mirqus@...il.com> Cc: netdev <netdev@...r.kernel.org>, Florian Fainelli <f.fainelli@...il.com>, Linux Kernel <linux-kernel@...r.kernel.org>, David Miller <davem@...emloft.net>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Eric Dumazet <eric.dumazet@...il.com> Subject: Re: [PATCH v4 2/2] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy() Thanks for giving feedback. On 21 August 2014 23:43, Michał Mirosław <mirqus@...il.com> wrote: > This has implicit: if (!skb) BUG(); There should probably be a return > or continue inside the if (!skb). Fixed, see v6 update (broken out to separate patch) which now includes increment to RX head counter > dma_sync_single_for_device() is not needed here as CPU does not and > should not write to the DMA_FROM_DEVICE mapping. Fixed, this was also broken out, dma_sync_single_for_device() moved to TX path. Maybe someone can verify this is the correct thing to do. Regards, Jonas -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists