netdev - Re: [PATCH v5 1/2] net: moxa: clear TX descriptor length bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACmBeS30_NUot6=FK3xNVDxfN+CPXNfNhEBcO4OPAOQ3Q9zQzw@mail.gmail.com>
Date:	Mon, 25 Aug 2014 16:23:35 +0200
From:	Jonas Jensen <jonas.jensen@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>, davem <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Michał Mirosław <mirqus@...il.com>
Subject: Re: [PATCH v5 1/2] net: moxa: clear TX descriptor length bits

Thanks for giving feedback.

On 20 August 2014 19:10, Eric Dumazet <eric.dumazet@...il.com> wrote:
> Wouldnt it be faster to not use readl() at all here ?

On 22 August 2014 06:39, David Miller <davem@...emloft.net> wrote:
> Like others I wonder why the existing descriptor value is being read
> at all.

It makes sense and I have verified, transfers continue to work
clearing the whole thing, see update in v6.


Regards,

   Jonas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html