netdev - Re: TCP output handling bug ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Aug 2014 22:13:41 -0400
From:	Dave Jones <davej@...hat.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, netdev@...r.kernel.org
Subject: Re: TCP output handling bug ?

On Thu, Aug 21, 2014 at 05:24:45PM -0700, Stephen Hemminger wrote:
 > On Thu, 21 Aug 2014 19:02:08 +0100
 > Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
 > 
 > > 
 > > tcp_send_syn_data:
 > > 
 > >         TCP_SKB_CB(data)->tcp_flags &= ~TCPHDR_SYN;
 > >         TCP_SKB_CB(data)->tcp_flags = (TCPHDR_ACK|TCPHDR_PSH);
 > > 
 > > the reporter has a point 8)
 > > 
 > > https://bugzilla.kernel.org/show_bug.cgi?id=82101
 > 
 > I wonder if covertity or smatch could be smart enough to catch this kind of bug?

For coverity: it should be, but isn't :)
I've pointed them at the bugzilla, maybe they can add a check in a
future update.

I bet this isn't the only instance of a bug like this left in the tree.
We've definitely had similar cases before.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html