netdev - Re: [PATCH net-next] net: Functions to report space available in device TX queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx8BJZPOH5zFFdXS0=RwRXqEiCmU-zLSbXLay2JCzyiKOA@mail.gmail.com>
Date:	Mon, 25 Aug 2014 08:18:51 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: Functions to report space available in
 device TX queues

On Sun, Aug 24, 2014 at 10:35 PM, David Miller <davem@...emloft.net> wrote:
> From: Tom Herbert <therbert@...gle.com>
> Date: Sun, 24 Aug 2014 13:19:47 -0700 (PDT)
>
>> +/**
>> + *   netdev_avail_queue - report how much space is availble for xmit
>> + *   @dev: network device
>> + *
>> + *   Report the amount of space available in the TX queue in terms of
>> + *   number of bytes. This returns the number of bytes avaiable per
>> + *   DQL. This function may be called without taking the txlock on
>> + *   the device, however in that case the result should be taken as
>> + *   a (strong) hint.
>> + */
>> +static inline int netdev_avail_queue(struct net_device *dev_queue)
>> +{
>> +     return netdev_tx_avail_queue(netdev_get_tx_queue(dev_queue, 0));
>> +}
>> +
>
> This doesn't make any sense, you're only providing queue zero's
> information.
>
It's consistent with the other BQL functions. netdev_*_queue is used
for single queue devices, netdev_tx_*_queue is used for specific
queues in MQ.

> You're passing in a net_device, calling it a "dev_queue" in the
> variable name, the exlicitly using queue zero of that device in the
> netdev_get_tx_queue() call.
>
Cut and paste prototype from netdev_reset_queue which was doing
that... I'll fix it.

> Pretty confusing if you ask me :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html