netdev - Re: [PATCH net-next] net: Functions to report space available in device TX queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7ODfX2oQTLE7mciSHyenQuC5MxBR4OCkfQK33qnC9+nxw@mail.gmail.com>
Date:	Mon, 25 Aug 2014 12:24:35 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: Functions to report space available in
 device TX queues

On Mon, Aug 25, 2014 at 8:18 AM, Tom Herbert <therbert@...gle.com> wrote:
> On Sun, Aug 24, 2014 at 10:35 PM, David Miller <davem@...emloft.net> wrote:
>> From: Tom Herbert <therbert@...gle.com>
>> Date: Sun, 24 Aug 2014 13:19:47 -0700 (PDT)
>>
>>> +/**
>>> + *   netdev_avail_queue - report how much space is availble for xmit
>>> + *   @dev: network device
>>> + *
>>> + *   Report the amount of space available in the TX queue in terms of
>>> + *   number of bytes. This returns the number of bytes avaiable per
>>> + *   DQL. This function may be called without taking the txlock on
>>> + *   the device, however in that case the result should be taken as
>>> + *   a (strong) hint.
>>> + */
>>> +static inline int netdev_avail_queue(struct net_device *dev_queue)
>>> +{
>>> +     return netdev_tx_avail_queue(netdev_get_tx_queue(dev_queue, 0));
>>> +}
>>> +
>>
>> This doesn't make any sense, you're only providing queue zero's
>> information.
>>
> It's consistent with the other BQL functions. netdev_*_queue is used
> for single queue devices, netdev_tx_*_queue is used for specific
> queues in MQ.
>

I was also confused by these names when I read the code, it doesn't
make sense to me either. We need some cleanup no matter of your
patch. I will try to do it after your patch is in.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html