lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140825.163135.1716545240924138406.davem@davemloft.net> Date: Mon, 25 Aug 2014 16:31:35 -0700 (PDT) From: David Miller <davem@...emloft.net> To: brouer@...hat.com Cc: dborkman@...hat.com, netdev@...r.kernel.org Subject: Re: [RFC PATCH net-next 1/3] ixgbe: support netdev_ops->ndo_xmit_flush() From: David Miller <davem@...emloft.net> Date: Mon, 25 Aug 2014 15:32:48 -0700 (PDT) > Jesper, just for fun, could you revert all of the xmit flush stuff and > test this patch instead? This doesn't work properly, sorry. We need to explicitly set xmit_more to zero before ->ndo_start_xmit() calls, because the initial zero'ing of that value isn't propagated in copy_skb_header() (nor do we want to add that). But I'm beyond convinced now that ->ndo_xmit_flush() is not the way to do this. I'm about to post a set of patches which will go into net-next which: 1) Converts the tree to skb->xmit_more 2) Adds Daniel's IXGBE conversion, adjusted for xmit_more. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists