lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 26 Aug 2014 08:13:43 +0200
From:	Daniel Borkmann <>
To:	David Miller <>
Subject: Re: [RFC PATCH net-next 1/3] ixgbe: support netdev_ops->ndo_xmit_flush()

On 08/26/2014 01:31 AM, David Miller wrote:
> From: David Miller <>
> Date: Mon, 25 Aug 2014 15:32:48 -0700 (PDT)
>> Jesper, just for fun, could you revert all of the xmit flush stuff and
>> test this patch instead?
> This doesn't work properly, sorry.  We need to explicitly set xmit_more
> to zero before ->ndo_start_xmit() calls, because the initial zero'ing
> of that value isn't propagated in copy_skb_header() (nor do we want to
> add that).
> But I'm beyond convinced now that ->ndo_xmit_flush() is not the way to
> do this.
> I'm about to post a set of patches which will go into net-next which:
> 1) Converts the tree to skb->xmit_more
> 2) Adds Daniel's IXGBE conversion, adjusted for xmit_more.

This seems indeed a better, more lightweight version to accomplish it.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists