lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Aug 2014 14:13:42 +0200 From: Oliver Neukum <oneukum@...e.de> To: Bjørn Mork <bjorn@...k.no> Cc: davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH] cdc-ether: clean packet filter upon probe On Mon, 2014-08-25 at 10:39 +0200, Bjørn Mork wrote: > Oliver Neukum <oneukum@...e.de> writes: > > On Fri, 2014-08-15 at 09:13 +0200, Bjørn Mork wrote: > >> Oliver Neukum <oneukum@...e.de> writes: > >> > >> > On Thu, 2014-08-14 at 13:11 +0200, Bjørn Mork wrote: > > > >> > Support for this request is mandatory. > >> > >> Yes, there is no problem for standard conforming ECM devices. I fully > >> agree there. > >> > >> But standard conformance is unfortunately not something we can expect. > >> My question was regarding the non-conforming devices, like the ones > >> supported by th zaurus and rndis_host drivers. These drivers are made > > > > You have a point. Yet another flag? Do you see an alternative? > > Note that I don't know whether this is a real problem or not. I don't > believe I have any zaurus or rndis_host devices. > > But how about just splitting the .bind functions for true ECM devices > and the others, letting the zaurus and rndis_host driver continue to use > usbnet_cdc_bind with no filter setting? Maybe define a new unexported > .bind in cdc_ether for this purpose, moving the ECM specific > initialization there? > > Maybe something along this (instead of the change to > usbnet_generic_cdc_bind)?: Yes, that looks superior. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists