netdev - Re: [RFC] crypto: tcrypt: new user interface with debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Aug 2014 20:14:55 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Luca Clementi <luca.clementi@...il.com>
Cc:	linux-crypto@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [RFC] crypto: tcrypt: new user interface with debugfs

On Sun, Aug 10, 2014 at 04:04:22AM +0000, Luca Clementi wrote:
> tcrypt is a kernel module which can be used to trigger speed tests on
> different parts of the crypto API. To trigger a test, users has to load the
> module using various module parameters, e.g.:
> 
>  # modprobe tcrypt mode=404 sec=5
> 
> All tcrypt tests are implemented in the _init function, their output is sent to
> the printk buffer, and once the test is over _init always returns a failure.
> 
> This patch modifies tcrypt in order to expose a debugfs user space interface
> which can be used to trigger tcrypt tests and to get their output. All tests
> output is redirected to an internal ring buffer.
> 
> The following files are available in the tcrypt debugfs directory:
> 
>  - command: this file can be use to control which test should be run simply
>             writing the test name to it. it also supports clearing the 'output'
>             buffer and listing all available tests
> 
>  - output:  holds a ring buffer with the output of the tests
> 
>  - seconds: this file can be used to control the number of seconds that a
>             tests should be run consecutively. If zero it uses CPU cycles
> 
> This patch is not for inclusion, but I'd like to know if my approach makes
> sense and if debugfs is the right place to expose a tcrypt interface.
> 
> Some functionalities available in the current version of the module are still
> missing in this version (in particular test_available and do_alg_test are not
> implemented yet). I also don't like the implementation of the 'fixed_tests' but
> as i said, this is just a prototype.
> 
> Signed-off-by: Luca Clementi <luca.clementi@...il.com>

It's certainly an interesting idea.  However, one of the attractive
things about the current setup is the ease of use.  So I'd like to
hear from others who use tcrypt on what they feel about converting
over to something like debugfs.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html