netdev - Re: [net-next v4 0/3] Refactor vxlan and l2tp to use common UDP tunnel APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140905.171942.713956165843587914.davem@davemloft.net>
Date:	Fri, 05 Sep 2014 17:19:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	azhou@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next v4 0/3] Refactor vxlan and l2tp to use common UDP
 tunnel APIs

From: Andy Zhou <azhou@...ira.com>
Date: Thu,  4 Sep 2014 00:57:39 -0700

> Andy Zhou (3):
>   udp-tunnel: Expand UDP tunnel APIs
>   vxlan: Refactor vxlan driver to make use of the common UDP tunnel
>     functions.
>   l2tp: Refactor l2tp core driver to make use of the common UDP tunnel 
>        functions

Way too many ifdefs in *.c code, and your indentation is not correct.
For function calls that span multiple lines, you must start the second
and subsequent lines exactly at the first column after the openning
parenthesis of the first line.  You must use the appropriate number of
TAB and SPACE characters necessary to do so.  If you are indenting these
lines only using TAB characters, you are very likely doing it wrong.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html