netdev - Re: [net-next v4 0/3] Refactor vxlan and l2tp to use common UDP tunnel APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2014 00:49:11 -0700
From:	Andy Zhou <azhou@...ira.com>
To:	David Miller <davem@...emloft.net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net-next v4 0/3] Refactor vxlan and l2tp to use common UDP
 tunnel APIs

Hi, David, thanks for the review. I have fixed the indentations for
functions as you pointed out.

I also plan to improve ifdefs in udp_tunnel.c in the next patch per
your suggestion.

However, vxlan.c and l2tp_core.c have many pre-exsisting ifdefs
(basically for CONFIG_IPV6). I am not sure if it make sense to remove
-- The readability may only improve marginally, if at all.  My patch
does not add new ones, but may move existing ones around as part of
re-factoring, I don't plan to make more changes to ,u current patch
series.

In case you still feel strongly we should clean up existing ifdefs
from vxlan.c and l2tp_core.c, I'd suggest that we work on separate
patches to deal with them. Does this make sense?

Andy

On Fri, Sep 5, 2014 at 5:19 PM, David Miller <davem@...emloft.net> wrote:
> From: Andy Zhou <azhou@...ira.com>
> Date: Thu,  4 Sep 2014 00:57:39 -0700
>
>> Andy Zhou (3):
>>   udp-tunnel: Expand UDP tunnel APIs
>>   vxlan: Refactor vxlan driver to make use of the common UDP tunnel
>>     functions.
>>   l2tp: Refactor l2tp core driver to make use of the common UDP tunnel
>>        functions
>
> Way too many ifdefs in *.c code, and your indentation is not correct.
> For function calls that span multiple lines, you must start the second
> and subsequent lines exactly at the first column after the openning
> parenthesis of the first line.  You must use the appropriate number of
> TAB and SPACE characters necessary to do so.  If you are indenting these
> lines only using TAB characters, you are very likely doing it wrong.
>
> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html