netdev - Re: [PATCH v2] irda: vlsi_ir: use %*ph specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140908.141011.2272191414764801766.davem@davemloft.net>
Date:	Mon, 08 Sep 2014 14:10:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andriy.shevchenko@...ux.intel.com
Cc:	samuel@...tiz.org, netdev@...r.kernel.org,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH v2] irda: vlsi_ir: use %*ph specifier

From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date: Mon,  8 Sep 2014 10:38:43 +0300

> Instead of looping in the code let's use kernel extension to dump small
> buffers.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Try again:

drivers/net/irda/vlsi_ir.c: In function ‘vlsi_proc_ring’:
drivers/net/irda/vlsi_ir.c:327:39: warning: comparison of distinct pointer types lacks a cast [enabled by default]

The types on each side of the min() expression are different, so the
compiler warns.  You probably need to use min_t() or similar, and
carefuly examine the possible effects of signed overflow etc.