lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1410161923-24783-1-git-send-email-andriy.shevchenko@linux.intel.com> Date: Mon, 8 Sep 2014 10:38:43 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Samuel Ortiz <samuel@...tiz.org>, netdev@...r.kernel.org, Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, David Miller <davem@...emloft.net> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Subject: [PATCH v2] irda: vlsi_ir: use %*ph specifier Instead of looping in the code let's use kernel extension to dump small buffers. Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> --- drivers/net/irda/vlsi_ir.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c index a04af9d..78e00ad 100644 --- a/drivers/net/irda/vlsi_ir.c +++ b/drivers/net/irda/vlsi_ir.c @@ -323,14 +323,8 @@ static void vlsi_proc_ring(struct seq_file *seq, struct vlsi_ring *r) j = (unsigned) rd_get_count(rd); seq_printf(seq, "current: rd = %d / status = %02x / len = %u\n", h, (unsigned)rd_get_status(rd), j); - if (j > 0) { - seq_printf(seq, " data:"); - if (j > 20) - j = 20; - for (i = 0; i < j; i++) - seq_printf(seq, " %02x", (unsigned)((unsigned char *)rd->buf)[i]); - seq_printf(seq, "\n"); - } + if (j > 0) + seq_printf(seq, " data: %*ph\n", min(j, 20), rd->buf); } for (i = 0; i < r->size; i++) { rd = &r->rd[i]; -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists