netdev - Re: [PATCH] net: Fix GRE RX to use skb_transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx-8eGG0aCX+2GhFmhygg44BLrqmt99aVuzv9JuDK4JZ9w@mail.gmail.com>
Date:	Mon, 8 Sep 2014 10:10:04 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: Fix GRE RX to use skb_transport_header for GRE
 header offset

On Mon, Sep 8, 2014 at 8:50 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Mon, 2014-09-08 at 08:29 -0700, Tom Herbert wrote:
>> GRE assumes that the GRE header is at skb_network_header +
>> ip_hrdlen(skb). It is more general to use skb_transport_header
>> and this allows the possbility of inserting additional header
>> between IP and GRE (which is what we will done in Generic UDP
>> Encapsulation for GRE).
>>
>> Signed-off-by: Tom Herbert <therbert@...gle.com>
>> ---
>>  net/ipv4/gre_demux.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> I am always confused why you do not include prior Acked-by when you
> repost same patch.
>
Sorry, I'll do that next time.

> This forces me to add it again.
>
> Note this should be a net-next patch, right ?
>
Yes.

> Acked-by: Eric Dumazet <edumazet@...gle.com>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html