netdev - Re: [Patch net-next] net_sched: fix suspicious RCU usage in cls_bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54175A6B.90602@intel.com>
Date:	Mon, 15 Sep 2014 14:30:19 -0700
From:	John Fastabend <john.r.fastabend@...el.com>
To:	Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
CC:	john.fastabend@...il.com, "David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next] net_sched: fix suspicious RCU usage in cls_bpf_classify()

On 09/15/2014 02:21 PM, Cong Wang wrote:
> Fixes: commit 1f947bf151e90ec0baad2948 ("net: sched: rcu'ify cls_bpf")
> Cc: John Fastabend <john.fastabend@...il.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  net/sched/cls_bpf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c
> index 6a7386e..4e3f5bf 100644
> --- a/net/sched/cls_bpf.c
> +++ b/net/sched/cls_bpf.c
> @@ -52,7 +52,7 @@ static const struct nla_policy bpf_policy[TCA_BPF_MAX + 1] = {
>  static int cls_bpf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
>  			    struct tcf_result *res)
>  {
> -	struct cls_bpf_head *head = rcu_dereference(tp->root);
> +	struct cls_bpf_head *head = rcu_dereference_bh(tp->root);
>  	struct cls_bpf_prog *prog;
>  	int ret;
>  
> 

you beat me to it.

Acked-by: John Fastabend <john.r.fastabend@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html