netdev - Re: [Patch net-next 1/4] net: fec: refine error handle of parser queue number from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140915.173247.59215420475562894.davem@davemloft.net>
Date:	Mon, 15 Sep 2014 17:32:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Frank.Li@...escale.com
Cc:	b38611@...escale.com, netdev@...r.kernel.org, lznuaa@...il.com,
	shawn.guo@...aro.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [Patch net-next 1/4] net: fec: refine error handle of parser
 queue number from DT

From: <Frank.Li@...escale.com>
Date: Tue, 16 Sep 2014 01:12:54 +0800

> -		dev_err(&pdev->dev, "Invalidate num_tx(=%d), fail back to 1\n",
> +		dev_warn(&pdev->dev, "Invalid num_tx(=%d), fall back to 1\n",
>  			*num_tx);

Any time you change the function name of a multi-line function call, you must
be mindful to adjust the indention of the subsequent argument lines, if
necessary.

>  	if (*num_rx < 1 || *num_rx > FEC_ENET_MAX_RX_QS) {
> -		dev_err(&pdev->dev, "Invalidate num_rx(=%d), fail back to 1\n",
> +		dev_warn(&pdev->dev, "Invalid num_rx(=%d), fall back to 1\n",
>  			*num_rx);

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html