netdev - Re: [Patch net-next 2/4] net: fec: add interrupt coalescence feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140915.173408.1107708227801679897.davem@davemloft.net>
Date:	Mon, 15 Sep 2014 17:34:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Frank.Li@...escale.com
Cc:	b38611@...escale.com, netdev@...r.kernel.org, lznuaa@...il.com,
	shawn.guo@...aro.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [Patch net-next 2/4] net: fec: add interrupt coalescence
 feature support

From: <Frank.Li@...escale.com>
Date: Tue, 16 Sep 2014 01:12:55 +0800

>  	unsigned int tx_align;
>  	unsigned int rx_align;
> +
> +	/* hw interrupt coalesce */
> +	uint rx_pkts_itr;
> +	uint rx_time_itr;
> +	uint tx_pkts_itr;
> +	uint tx_time_itr;

Please use explicit "unsigned int" just like the lines right above the ones
you are adding.

> +	/* Must be greater than zero to avoid unpredictable behavior */
> +	if (!fep->rx_time_itr || !fep->rx_pkts_itr ||
> +		!fep->tx_time_itr || !fep->tx_pkts_itr)

This is not indented properly.

On the second and subsequent lines of a multi-line conditional, things
must start exactly at the first column after the openning parenthesis
of the first line.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html