netdev - Re: [PATCH net-next] of: mdio: honor flags passed to of_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140916.163951.1456738615389200706.davem@davemloft.net>
Date:	Tue, 16 Sep 2014 16:39:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next] of: mdio: honor flags passed to of_phy_connect

From: Florian Fainelli <f.fainelli@...il.com>
Date: Tue, 16 Sep 2014 10:49:36 -0700

> Commit f9a8f83b04e0 ("net: phy: remove flags argument from phy_{attach,
> connect, connect_direct}") removed the flags argument to the PHY library
> calls to: phy_{attach,connect,connect_direct}.
> 
> Most Device Tree aware drivers call of_phy_connect() with the flag
> argument set to 0, but some of them might want to set a different value
> there in order for the PHY driver to key a specific behavior based on
> the phy_device::dev_flags value.
> 
> Allow such drivers to set custom dev_flags as part of the
> of_phy_connect() call since of_phy_connect() does start the PHY state
> machine, it will call into the PHY driver config_init() callback which
> is usually where a specific phy_flags value is important.
> 
> Fixes: f9a8f83b04e0 ("net: phy: remove flags argument from phy_{attach, connect, connect_direct}")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

I do not see anyone passing non-zero in as the flags argument.

It is difficult for me to determine the impact of this patch,
whether it should really go to 'net' and/or 'stable', etc.
if you don't tell me who this could possibly break.

It's even worse when I do all of the searching around and
cannot find a breakage case myself. :-/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html