netdev - Re: [PATCH net-next] of: mdio: honor flags passed to of_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5418A1CC.9090704@gmail.com>
Date:	Tue, 16 Sep 2014 13:47:08 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next] of: mdio: honor flags passed to of_phy_connect

On 09/16/2014 01:39 PM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Tue, 16 Sep 2014 10:49:36 -0700
> 
>> Commit f9a8f83b04e0 ("net: phy: remove flags argument from phy_{attach,
>> connect, connect_direct}") removed the flags argument to the PHY library
>> calls to: phy_{attach,connect,connect_direct}.
>>
>> Most Device Tree aware drivers call of_phy_connect() with the flag
>> argument set to 0, but some of them might want to set a different value
>> there in order for the PHY driver to key a specific behavior based on
>> the phy_device::dev_flags value.
>>
>> Allow such drivers to set custom dev_flags as part of the
>> of_phy_connect() call since of_phy_connect() does start the PHY state
>> machine, it will call into the PHY driver config_init() callback which
>> is usually where a specific phy_flags value is important.
>>
>> Fixes: f9a8f83b04e0 ("net: phy: remove flags argument from phy_{attach, connect, connect_direct}")
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> 
> I do not see anyone passing non-zero in as the flags argument.

Right, I have a follow-up patch that will pass non-zero, I will just
submit everything at once so it is clear in what context and purpose
this gets used.

Thanks!

> 
> It is difficult for me to determine the impact of this patch,
> whether it should really go to 'net' and/or 'stable', etc.
> if you don't tell me who this could possibly break.
> 
> It's even worse when I do all of the searching around and
> cannot find a breakage case myself. :-/
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html