lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 17 Sep 2014 10:31:40 -0700
From:	John Fastabend <john.fastabend@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
CC:	Oliver Hartkopp <socketcan@...tkopp.net>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [net-next PATCH] net: sched: cls_u32: rcu can not be last node

On 09/17/2014 09:40 AM, Cong Wang wrote:
> On Tue, Sep 16, 2014 at 10:54 PM, Oliver Hartkopp
> <socketcan@...tkopp.net> wrote:
>> Please add an appropriate comment to the *code* to prevent this knowledge to
>> disappear. No one will search/find this in git commit messages next time.
>>
>
> +1
>
> Even though I dig git log, I agree adding a one-line comment is better.
>

Sure I'll add a comment at the end of the structure.

Thanks.

-- 
John Fastabend         Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists