lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Sep 2014 10:48:02 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: John Fastabend <john.fastabend@...il.com> Cc: xiyou.wangcong@...il.com, davem@...emloft.net, netdev@...r.kernel.org, jhs@...atatu.com Subject: Re: [net-next PATCH v2] net: sched: cls_u32: rcu can not be last node On Wed, 2014-09-17 at 10:31 -0700, John Fastabend wrote: > tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the > structure and pads the structure with tc_u32_key fields for each key. > > kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL) > > CC: Eric Dumazet <edumazet@...gle.com> > Signed-off-by: John Fastabend <john.r.fastabend@...el.com> > --- > net/sched/cls_u32.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c > index eceeb04..8462132 100644 > --- a/net/sched/cls_u32.c > +++ b/net/sched/cls_u32.c > @@ -64,8 +64,9 @@ struct tc_u_knode { > u32 __percpu *pcpu_success; > #endif > struct tcf_proto *tp; > - struct tc_u32_sel sel; > struct rcu_head rcu; > + struct tc_u32_sel sel; > + /* tc_u32_keys allocated at end of structure */ > }; > > struct tc_u_hnode { Sorry to be picky, but comment should be before 'sel' or at same line. It should mention that 'sel' MUST be last field. Thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists