netdev - Re: cannot ARP macvlan on top of bonding device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1411162332.26859.36.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 19 Sep 2014 14:32:12 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Francesco Ruggeri <fruggeri@...stanetworks.com>
Cc:	netdev@...r.kernel.org, fruggeri@...sta.com, davem@...emloft.net,
	herbert@...dor.apana.org.au
Subject: Re: cannot ARP macvlan on top of bonding device

On Fri, 2014-09-19 at 14:17 -0700, Eric Dumazet wrote:

> You're right, we probably should use netdev_max_backlog instead.
> 
> Please send a formal patch ?

BTW, we should add a cond_resched() in macvlan_process_broadcast() ...

It also seems MACVLAN_SKB_CB(skb)->src escapes an RCU protected region,
without taking a refcount on struct macvlan_dev

This seems racy to me :(



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html